Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29631 )

Change subject: Rearrange ctrl interface code ......................................................................

Patch Set 2:

(11 comments)

File src/osmo-bsc/bsc_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/062aebd4_894b7399 PS2, Line 371: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/19c6d907_731fc604 PS2, Line 392: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/a0620cca_35c39048 PS2, Line 670: * transferred, to permit caller to send the same CMD to several ASPs. please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/f2adc081_8344f3ff PS2, Line 671: * Caller must hence free 'cmd' itself. please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/d55a62ee_d3d29606 PS2, Line 857: } adding a line without newline at end of file

File src/osmo-bsc/bts_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/01467bc9_6d668bb4 PS2, Line 70: LOGP(DCTRL, LOGL_DEBUG, "Found %i positions.\n", i); Use %d instead of %i

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/f0976b45_fe4d9745 PS2, Line 87: cmd->variable = talloc_asprintf(cmd, "bts.%i.location-state", bts->nr); Use %d instead of %i

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/85e212d1_5d83b14c PS2, Line 129: } else { else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/59a4b488_1cc89628 PS2, Line 649: rc =bsc_bts_trx_ctrl_cmds_install(); spaces required around that '=' (ctx:WxV)

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/ed04cd1f_f044428a PS2, Line 652: } adding a line without newline at end of file

File src/osmo-bsc/bts_trx_ctrl.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/04ba9752_bb2ed976 PS2, Line 119: } adding a line without newline at end of file