Attention is currently required from: pespin.

View Change

11 comments:

• File src/osmo-bsc/bsc_ctrl.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 371: struct gsm_network *net = (struct gsm_network*)cmd->node;

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 392: struct gsm_network *net = (struct gsm_network*)cmd->node;

    "(foo*)" should be "(foo *)"

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 670: * transferred, to permit caller to send the same CMD to several ASPs.

    please, no space before tabs

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 671: * Caller must hence free 'cmd' itself.

    please, no space before tabs

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 857: }

    adding a line without newline at end of file

• File src/osmo-bsc/bts_ctrl.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 70: LOGP(DCTRL, LOGL_DEBUG, "Found %i positions.\n", i);

    Use %d instead of %i

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 87: cmd->variable = talloc_asprintf(cmd, "bts.%i.location-state", bts->nr);

    Use %d instead of %i

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 129: } else {

    else is not generally useful after a break or return

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 649: rc =bsc_bts_trx_ctrl_cmds_install();

    spaces required around that '=' (ctx:WxV)

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 652: }

    adding a line without newline at end of file

• File src/osmo-bsc/bts_trx_ctrl.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-921):

    Patch Set #2, Line 119: }

    adding a line without newline at end of file

To view, visit change 29631. To unsubscribe, or for help writing mail filters, visit settings.