Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email )
Change subject: Improve logging reading packets from gtp device ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-upf/upf_gtpu_echo.c:
https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/3a4e0337_36fe3819?usp=... : PS1, Line 219: return 0;
You're changing the logic: before your patch it would return `-1`, but now it's returning `0` -- is […]
It's just a regular ofd cb, the return code is not really used unless you pass -EBADF. I changed it because imho it's just fine returning 0 since it's a expected code path (even if we are not yet doing anything with it other than logging).
-
pespin