Attention is currently required from: fixeria, osmith.

View Change

1 comment:

• File src/osmo-upf/upf_gtpu_echo.c:

  • Patch Set #1, Line 219: return 0;

    You're changing the logic: before your patch it would return `-1`, but now it's returning `0` -- is […]

    It's just a regular ofd cb, the return code is not really used unless you pass -EBADF.
    I changed it because imho it's just fine returning 0 since it's a expected code path (even if we are not yet doing anything with it other than logging).

To view, visit change 39419. To unsubscribe, or for help writing mail filters, visit settings.