Attention is currently required from: osmith, Hoernchen, neels, fixeria, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 )
Change subject: Add osmo_io with initial poll backend ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f3774e3f_863afd46 PS8, Line 169: llist_add_tail(&msghdr->list, &iofd->tx_queue.msg_queue); Could be msgb_enqueue_count(), but it can stay this way too.
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/97d19e82_37b0b785 PS8, Line 206: iofd->tx_queue.current_length--; Could be msgb_dequeue_count(), but can stay this way too.
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/25c87e73_39e41f78 PS8, Line 85: if (iofd->closed) is this the new -EBADF to handle case where recvmsg_cb closes th iofd? What if iofd is freed by recvmsg_cb(), can that happen? you would be accessing freed memory here.