Attention is currently required from: osmith, Hoernchen, neels, fixeria, daniel.

Patch set 8:Code-Review +1

View Change

3 comments:

• File src/core/osmo_io.c:

  • Patch Set #8, Line 169: llist_add_tail(&msghdr->list, &iofd->tx_queue.msg_queue);

    Could be msgb_enqueue_count(), but it can stay this way too.

  • Patch Set #8, Line 206: iofd->tx_queue.current_length--;

    Could be msgb_dequeue_count(), but can stay this way too.

• File src/core/osmo_io_poll.c:

  • Patch Set #8, Line 85: if (iofd->closed)

    is this the new -EBADF to handle case where recvmsg_cb closes th iofd? What if iofd is freed by recvmsg_cb(), can that happen? you would be accessing freed memory here.

To view, visit change 30934. To unsubscribe, or for help writing mail filters, visit settings.