Attention is currently required from: pespin.

kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email )

Change subject: trx_toolkit/*: Try to avoid copying burst data where possible ......................................................................

Patch Set 2:

(3 comments)

Patchset:

PS2: (amended the patch with suggested changes)

File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/33ecf10a_bf5d84e5?us... : PS1, Line 230: msg_burst = memoryview(msg)[self.HDR_LEN:]

Not sure if it's really noticeable, you may even skip the memoryview/slice here by checking: […]

Indeed, this will save a bit for nope indication. Thanks.

https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/27ca53c7_7667f852?us... : PS1, Line 336: burst = burst[:EDGE_BURST_LEN]

Can you maybe use the memoryview() thing here too?

Indeed, thanks. (but I did not touch this lines because I verified that they do not get executed in my test)