Attention is currently required from: pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    (amended the patch with suggested changes)

• File src/target/trx_toolkit/data_msg.py:

  • Patch Set #1, Line 230: msg_burst = memoryview(msg)[self.HDR_LEN:]

    Not sure if it's really noticeable, you may even skip the memoryview/slice here by checking: […]

    Indeed, this will save a bit for nope indication. Thanks.

  • Patch Set #1, Line 336: burst = burst[:EDGE_BURST_LEN]

    Can you maybe use the memoryview() thing here too?

    Indeed, thanks. (but I did not touch this lines because I verified that they do not get executed in my test)

To view, visit change 39537. To unsubscribe, or for help writing mail filters, visit settings.