Attention is currently required from: pespin, fixeria, daniel.

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )

Change subject: gsm/ipa: Add segmentation callback ......................................................................

Patch Set 7:

(2 comments)

File src/gsm/ipa.c:

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/4a90f3af_263bed01 PS5, Line 722: int ipa_segmentation_cb(struct msgb *msg)

Documentation should be added in the same commit where the function is added.

Ah I see now that my message was cut off. The change mentioned adds a Doxygen-comment to the `struct osmo_io_ops` definition explaining semantics. I have added a comment referring to the struct def..

https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/699e8871_5f383e51 PS5, Line 725: /* Haven't even the read entire header */

this sentence looks wrongly written

I don't see anything wrong with it