Attention is currently required from: pespin, fixeria, daniel.

View Change

2 comments:

• File src/gsm/ipa.c:

  • Patch Set #5, Line 722: int ipa_segmentation_cb(struct msgb *msg)

    Documentation should be added in the same commit where the function is added.

    Ah I see now that my message was cut off. The change mentioned adds a Doxygen-comment to the `struct osmo_io_ops` definition explaining semantics.
    I have added a comment referring to the struct def..

  • Patch Set #5, Line 725: /* Haven't even the read entire header */

    this sentence looks wrongly written

    I don't see anything wrong with it

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.