Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ......................................................................
Patch Set 1:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37685/comment/b9303aba_75aeda5b PS1, Line 832: '--adm-type',
add `default='ADM1'`?
No, that would break the default ADM number being retrieved from the CardProfile. For sysmocom that's always ADM1, but for e.g. Fairwaves its 2 (or 3).
https://gerrit.osmocom.org/c/pysim/+/37685/comment/565977c5_73e8e8bc PS1, Line 842: inverse
`reverse()`?
https://bidict.readthedocs.io/en/main/basic-usage.html uses the inverse[] approach. I couldn't immediately find a reverse() method documentation?