Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email ) Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm' ...................................................................... Patch Set 1: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37685/comment/b9303aba_75aeda5b PS1, Line 832: '--adm-type',
add `default='ADM1'`? No, that would break the default ADM number being retrieved from the CardProfile. For sysmocom that's always ADM1, but for e.g. Fairwaves its 2 (or 3).
https://gerrit.osmocom.org/c/pysim/+/37685/comment/565977c5_73e8e8bc PS1, Line 842: inverse
`reverse()`? https://bidict.readthedocs.io/en/main/basic-usage.html uses the inverse[] approach. I couldn't immediately find a reverse() method documentation?
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44 Gerrit-Change-Number: 37685 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 13:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment