Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email )
Change subject: Use talloc to allocate asn1c decoded structs
......................................................................
Patch Set 2:
(1 comment)
File src/tcap.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/7a04f583_07f1... :
PS2, Line 29: vo
we're not using some linker script to hide symbols from exporting
we are, see libosmo_asn1_tcap_la_LDFLAGS in my previous comment.
I would say if we go for a setter method, then there should be a getter method and no publicly visible context symbol at all.
The symbol is not visible as per mentioned above. The pointer can be obtained by using the return of the API osmo_asn1_tcap_set_talloc_ctx().
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9
Gerrit-Change-Number: 42219
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 26 Feb 2026 15:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
pespin