Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith.

View Change

1 comment:

• File src/tcap.c:

  • Patch Set #2, Line 29: vo

    we're not using some linker script to hide symbols from exporting

    we are, see libosmo_asn1_tcap_la_LDFLAGS in my previous comment.

    I would say if we go for a setter method, then there should be a getter method and no publicly visible context symbol at all.

    The symbol is not visible as per mentioned above. The pointer can be obtained by using the return of the API osmo_asn1_tcap_set_talloc_ctx().

To view, visit change 42219. To unsubscribe, or for help writing mail filters, visit settings.