Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265?usp=email )

Change subject: sctp_proxy: fix no-op 'connecting' state timeout ......................................................................

Patch Set 1:

(2 comments)

File src/sctp_proxy.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/cd0d45a2_9fb1a... PS1, Line 85: connecting(enter, OldState, tip: I find it useful to prefix these state functions with "st_", this way it's clearer they are part of the FSM

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37265/comment/003d8c0c_f7b99... PS1, Line 90: {next_state, connecting, S#{sock => Sock}, Reentering the state from withing the enter phase looks a bit werid to me tbh. I think it's totally fine and the proper thing to do to "keep_state" in here, I did that in osmo-pedg and it was working with ttcn3 tests afair.

The problem I think is that in line 94 connecting_timeout, instead of shutting down you actually need to do "{next_state, connecting, ...}"

Feel free to look at it or merge it if anyway it works for you...