Attention is currently required from: fixeria.

View Change

2 comments:

• File src/sctp_proxy.erl:

  • Patch Set #1, Line 85: connecting(enter, OldState,

    tip: I find it useful to prefix these state functions with "st_", this way it's clearer they are part of the FSM

  • Patch Set #1, Line 90: {next_state, connecting, S#{sock => Sock},

    Reentering the state from withing the enter phase looks a bit werid to me tbh. I think it's totally fine and the proper thing to do to "keep_state" in here, I did that in osmo-pedg and it was working with ttcn3 tests afair.

    The problem I think is that in line 94 connecting_timeout, instead of shutting down you actually need to do "{next_state, connecting, ...}"

    Feel free to look at it or merge it if anyway it works for you...

To view, visit change 37265. To unsubscribe, or for help writing mail filters, visit settings.