Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35778?usp=email ) Change subject: trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH ...................................................................... Patch Set 1: (2 comments) File src/host/trxcon/src/sched_lchan_pdtch.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35778/comment/c5a6b507_55d351ff PS1, Line 164: lchan->prim = msg I will add an `ASSERT` to make sure `lchan->prim` is NULL here. https://gerrit.osmocom.org/c/osmocom-bb/+/35778/comment/4d8458da_dc9c81e3 PS1, Line 191: } `lchan->prim` should remain allocated and assigned until `bid == 3` (4th burst) - this is when we want to confirm sending UL BLOCK.req to the upper layers, because burst timing matters. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If32fafeef0ea347ed3800e6b67349bf12e66047f Gerrit-Change-Number: 35778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Feb 2024 13:05:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment