Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )

Change subject: WIP: vty: Add check against sensible default value for ny1 ......................................................................

Patch Set 2:

(2 comments)

This change is ready for review.

File src/osmo-bsc/bts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/8acd32f4_09665f3d PS1, Line 535: unsigned long ny1;

Lots of code here given that you already have a helper func.... […]

I didn't want to move those lines into the function, because @bts.c@ doesn't include any logging, so I thought it isn't supposed to have any logging functions. Also on startup, a wrong value of Ny1 is supposed to lead to a connection shutdown, but during runtime, you mentioned logging a notice. Hence I thought different logs maybe.

Anyways, then I'll assume it's okay to include the needed headers for logging in @bts.c@?

File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/4cb3bf29_441c72d2 PS1, Line 96: unsigned long ny1;

I think this is not needed here if you are already testing it during BTS setup in the other file.

I thought reconfiguration of Ny1 during runtime might be a scenario which is why I added both checks (I think the config check only checks on startup...). Not important?