Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/bts.c:

  • Patch Set #1, Line 535: unsigned long ny1;

    Lots of code here given that you already have a helper func.... […]

    I didn't want to move those lines into the function, because @bts.c@ doesn't include any logging, so I thought it isn't supposed to have any logging functions. Also on startup, a wrong value of Ny1 is supposed to lead to a connection shutdown, but during runtime, you mentioned logging a notice. Hence I thought different logs maybe.

    Anyways, then I'll assume it's okay to include the needed headers for logging in @bts.c@?

• File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

  • Patch Set #1, Line 96: unsigned long ny1;

    I think this is not needed here if you are already testing it during BTS setup in the other file.

    I thought reconfiguration of Ny1 during runtime might be a scenario which is why I added both checks (I think the config check only checks on startup...). Not important?

To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.