Attention is currently required from: osmith.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 )

Change subject: Add initial CSD support with external MNCC ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/msc/transaction.h:

https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/bbb3a0dd_84809fc6 PS1, Line 113: struct csd_filter csd; union between codecs and csd makes sense?

File src/libmsc/csd_filter.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/497366ae_e4edebfe PS1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]); I see no benefit and several drawbacks in they way you are doing this, instead of calling the function once for each type: csd_bs_list_add_bs(list, CSD_BS_24_T_V110_2k4); csd_bs_list_add_bs(list, CSD_BS_25_T_V110_4k8); ....

https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/c14eb799_e3534326 PS1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]); same