Attention is currently required from: osmith.

View Change

3 comments:

• File include/osmocom/msc/transaction.h:

  • Patch Set #1, Line 113: struct csd_filter csd;

    union between codecs and csd makes sense?

• File src/libmsc/csd_filter.c:

  • Patch Set #1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]);

    I see no benefit and several drawbacks in they way you are doing this, instead of calling the function once for each type:
    csd_bs_list_add_bs(list, CSD_BS_24_T_V110_2k4);
    csd_bs_list_add_bs(list, CSD_BS_25_T_V110_4k8);
    ....

  • Patch Set #1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]);

    same

To view, visit change 33369. To unsubscribe, or for help writing mail filters, visit settings.