Attention is currently required from: fixeria, keith, laforge.
pespin has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )
Change subject: Fix missing LAC/CI hashtable update upon CTRL SET ......................................................................
Patch Set 8:
(5 comments)
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/d0bc2d31_dc7e7d21?usp=... : PS6, Line 828: int gsm_bts_set_lac(struct gsm_bts *bts, int lac);
uint16_t lac
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/36fbe203_512a72b6?usp=... : PS6, Line 829: int gsm_bts_set_ci(struct gsm_bts *bts, int ci);
uint16_t cell_identity
Done
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/63bf7deb_85bb4779?usp=... : PS6, Line 769: return
I'm not such a big fan of functions unconditionally returning zero, especially if the caller doesn't […]
Done
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/c99f6c70_e17f9031?usp=... : PS6, Line 250: cmd->reply = talloc_asprintf(cmd, "%d", bts->location_area_code);
PRIu16
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/b640b678_9f792d38?usp=... : PS6, Line 286: cmd->reply = talloc_asprintf(cmd, "%d", bts->cell_identity);
PRIu16
Done
-
pespin