Attention is currently required from: fixeria, keith, laforge.

View Change

5 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #6, Line 828: int gsm_bts_set_lac(struct gsm_bts *bts, int lac);

    uint16_t lac

    Done

  • Patch Set #6, Line 829: int gsm_bts_set_ci(struct gsm_bts *bts, int ci);

    uint16_t cell_identity

    Done

• File src/osmo-bsc/bts.c:

  • Patch Set #6, Line 769: return

    I'm not such a big fan of functions unconditionally returning zero, especially if the caller doesn't […]

    Done

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #6, Line 250: cmd->reply = talloc_asprintf(cmd, "%d", bts->location_area_code);

    PRIu16

    Done

  • Patch Set #6, Line 286: cmd->reply = talloc_asprintf(cmd, "%d", bts->cell_identity);

    PRIu16

    Done

To view, visit change 40917. To unsubscribe, or for help writing mail filters, visit settings.