Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30081 ) Change subject: asn1: fix visibility warnings from generated code ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: The asn1 files were already modified quite a bit to make asn1c digest them at all. look at the git commit log of the asn1 subdirectory and you'll find commits like 355d9513c0359ec10de79cc12b6e8a2d4e81e8d8 "Rewrite to avoid information object classes". So there's no difference here, other than it's 'just' warnings. What I'm more worried about is that I don't have deep enough ASN.1 and various encoding rules knowledge if this kind of change really doesn't affect the binary encoding/decoding. Only encoding/decoding tests with a reasonably sized body of binary messages would make us notice that, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If84445ed2e0df604b581684dcf83f8520b7da84c Gerrit-Change-Number: 30081 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Nov 2022 22:00:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment