Attention is currently required from: osmith, pespin.
1 comment:
Patchset:
I'm not sure we want to touch the asn files. […]
The asn1 files were already modified quite a bit to make asn1c digest them at all. look at the git commit log of the asn1 subdirectory and you'll find commits like 355d9513c0359ec10de79cc12b6e8a2d4e81e8d8 "Rewrite to avoid information object classes".
So there's no difference here, other than it's 'just' warnings.
What I'm more worried about is that I don't have deep enough ASN.1 and various encoding rules knowledge if this kind of change really doesn't affect the binary encoding/decoding. Only encoding/decoding tests with a reasonably sized body of binary messages would make us notice that, right?
To view, visit change 30081. To unsubscribe, or for help writing mail filters, visit settings.