Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 10: (4 comments) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/f988b478_1a09e725?usp… : PS10, Line 869: /* find all RNCs which are serving this RNC */ something is wrong in this sentence regarding a "RNC serving a RNC". https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c7712193_cbef768f?usp… : PS10, Line 878: osmo_rnc_id_name(&rnc->rnc_id), this indentation may be wrong. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/2265ae3a_9a516874?usp… : PS10, Line 883: } else if (!is_ps && !osmo_lai_cmp(&entry->rai.lac, &ra_id->lac)) { this "else" can be removed in this line, simplifying logic. https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/e7f0ba47_6dd5bc39?usp… : PS10, Line 932: return iu_page2(imsi, tmsi, &rai, false); I really wonder, does it really make sense to have a helper function for both CS and PS where you actually mix the logic for both and then have an extra copy here? Looks like you should simply implement CS here and PS below, ad be done with it? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:06:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No