Attention is currently required from: lynxis lazus.

View Change

4 comments:

• File src/iu_client.c:

  • Patch Set #10, Line 869: /* find all RNCs which are serving this RNC */

    something is wrong in this sentence regarding a "RNC serving a RNC".

  • Patch Set #10, Line 878: osmo_rnc_id_name(&rnc->rnc_id),

    this indentation may be wrong.

  • Patch Set #10, Line 883: } else if (!is_ps && !osmo_lai_cmp(&entry->rai.lac, &ra_id->lac)) {

    this "else" can be removed in this line, simplifying logic.

  • Patch Set #10, Line 932: return iu_page2(imsi, tmsi, &rai, false);

    I really wonder, does it really make sense to have a helper function for both CS and PS where you actually mix the logic for both and then have an extra copy here?

    Looks like you should simply implement CS here and PS below, ad be done with it?

To view, visit change 38946. To unsubscribe, or for help writing mail filters, visit settings.