Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/185a6aa4_a806beb9 PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
Well, this "usual" naming does not apply here: […]
I modeled this code after the existing one for EUSEs and USSD routes, which - as @fixeria noted - uses _del rather than _free. What is the community consensus here? Should I change my patch to use _free? Should all existing usage of _del in osmo-hlr also be changed to _free?
-
falconia