[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs... - gerrit-log

30 Apr 2023


      Attention is currently required from: pespin, lynxis lazus.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 )
Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/hlr/gsup_server.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/381b7d69_43470357 
PS3, Line 71: osmo_gsup_create_insert_subscriber_data_msg
this looks like a public API function of libosmo-gsup to me?  In that case, we cannot simply break ABI and API.  We must introduce another function for the new behavior, keeping the old one for backwards compatibiliy.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c
Gerrit-Change-Number: 32511
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: msuraev msuraev@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 30 Apr 2023 00:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment