Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29865 )
Change subject: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/ ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/9fd3f384_feb19791 PS1, Line 986: rs might as well fix this typo too while at it (and use full line width maybe)
https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/e1a934e8_c255362e PS1, Line 987: static int mgcp_rtp_conn_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg) mgcp_conn_rtp_dispatch_rtp()
the struct is called 'mgcp_conn_rtp', we have three functions in the form 'mgcp_conn_rtp_*' matching the struct name, and two mismatching 'mgcp_rtp_conn_*' -- maybe it would be better to stick with a name matching the struct name.