Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #1, Line 986: rs

    might as well fix this typo too while at it (and use full line width maybe)

  • Patch Set #1, Line 987: static int mgcp_rtp_conn_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg)

    mgcp_conn_rtp_dispatch_rtp()

    the struct is called 'mgcp_conn_rtp', we have three functions in the form 'mgcp_conn_rtp_*' matching the struct name, and two mismatching 'mgcp_rtp_conn_*' -- maybe it would be better to stick with a name matching the struct name.

To view, visit change 29865. To unsubscribe, or for help writing mail filters, visit settings.