Attention is currently required from: falconia, fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/d1f1d868_a06df5b1
PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
@laforge says that alloc+del is inconsistent, instead it should be either alloc+free or add+del - an […]
For me, 2) is optional here since it's not really related to the current patchset at hand. Of course I'm happy if you want to do it too.
IMHO the only thing you need to do is s/smsc_del/smsc_free/.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I1624dcd9d22b4efca965ccdd1c74f0063a94a33c
Gerrit-Change-Number: 34448
Gerrit-PatchSet: 2
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 20 Sep 2023 11:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
pespin