Attention is currently required from: falconia, fixeria, laforge.

View Change

1 comment:

• File include/osmocom/hlr/hlr_sms.h:

  • Patch Set #2, Line 17: void smsc_del(struct hlr_smsc *smsc);

    @laforge says that alloc+del is inconsistent, instead it should be either alloc+free or add+del - an […]

    For me, 2) is optional here since it's not really related to the current patchset at hand. Of course I'm happy if you want to do it too.

    IMHO the only thing you need to do is s/smsc_del/smsc_free/.

To view, visit change 34448. To unsubscribe, or for help writing mail filters, visit settings.