Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892 )
Change subject: bsc (WIP): Make socket queue max. length configurable ......................................................................
Patch Set 1:
(4 comments)
File include/osmocom/bsc/pcu_if.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/93934368_b44f4316 PS1, Line 12: #define BSC_CFG_PCU_SOCK_WQUEUE_LEN_MAX_MAX 2147483646 I don't really think this is really needed, just use the value directly.
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/406fedbe_14fc66e8 PS1, Line 2487: if (fd >= 0 && ((ofd = osmo_fd_get_by_fd(fd)) != NULL)) { why do you need this? I don't see the point.
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/cca3c42d_b9504858 PS1, Line 2491: } btw, if the queue is already created you should update the max len there.
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/fbbe6d5f_3a403035 PS1, Line 956: net->pcu_sock_fd = rc; this looks really unrelated.
-
pespin