Attention is currently required from: arehbein.

View Change

4 comments:

• File include/osmocom/bsc/pcu_if.h:

  • Patch Set #1, Line 12: #define BSC_CFG_PCU_SOCK_WQUEUE_LEN_MAX_MAX 2147483646

    I don't really think this is really needed, just use the value directly.

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 2487: if (fd >= 0 && ((ofd = osmo_fd_get_by_fd(fd)) != NULL)) {

    why do you need this? I don't see the point.

  • Patch Set #1, Line 2491: }

    btw, if the queue is already created you should update the max len there.

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #1, Line 956: net->pcu_sock_fd = rc;

    this looks really unrelated.

To view, visit change 33892. To unsubscribe, or for help writing mail filters, visit settings.