Attention is currently required from: fixeria, dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 )

Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ......................................................................

Patch Set 4:

(2 comments)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/33690/comment/67ce13fb_86eba0d8 PS4, Line 41: self._aids = []

thanks, this should be in the constructor.

Done

https://gerrit.osmocom.org/c/pysim/+/33690/comment/9f4d2de6_152df544 PS4, Line 319: SimCard

`UiccCardBase` is a [grand]child of `SimCard`, do we really need `SimCard` here?

indeed. In our code model we don't need SimCard here, but from a ETSI/3GPP point of view a [typical] Usim is UICC + SIM. The reason we have the "wrong" relationship of UiccCardBase inheriting from SimCardBase instead of CardBase is that the read_{binary,record} methods are identical.

Maye I should simply copy+paste those 10 lines of code and maeke UiccCardBase inherit from CardBase rather than SimCard?