Attention is currently required from: fixeria, dexter.

View Change

2 comments:

• File pySim/cards.py:

  • Patch Set #4, Line 41: self._aids = []

    thanks, this should be in the constructor.

    Done

  • Patch Set #4, Line 319: SimCard

    `UiccCardBase` is a [grand]child of `SimCard`, do we really need `SimCard` here?

    indeed. In our code model we don't need SimCard here, but from a ETSI/3GPP point of view a [typical] Usim is UICC + SIM. The reason we have the "wrong" relationship of UiccCardBase inheriting from SimCardBase instead of CardBase is that the read_{binary,record} methods are identical.

    Maye I should simply copy+paste those 10 lines of code and maeke UiccCardBase inherit from CardBase rather than SimCard?

To view, visit change 33690. To unsubscribe, or for help writing mail filters, visit settings.