pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email ) Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... ipaccess: Fix wrong pointer passed in sign_link_up user callback This bug was introduced in Jun 2011, 13 years ago, so probably this code path is not (usually) used at all. The commit introducing the regression changed sign_link_up() first param from msgb to struct ipaccess_unit, but compiler didn't catch it because it's being passed as a void pointer. Fixes: c9c4fd39055ab02c0af59d5519e62edc456e3d0b Related: OS#3622 Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index da2f04d..f89db15 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -955,9 +955,9 @@ if (ret == 1 && hh->proto == IPAC_PROTO_IPACCESS) { if (msg_type == IPAC_MSGT_ID_GET) { - sign_link = link->line->ops->sign_link_up(msg, - link->line, - link->ofd->priv_nr); + sign_link = link->line->ops->sign_link_up(link->line->ops->cfg.ipa.dev, + link->line, + link->ofd->priv_nr); if (sign_link == NULL) { LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>