pespin submitted this change.

View Change

ipaccess: Fix wrong pointer passed in sign_link_up user callback

This bug was introduced in Jun 2011, 13 years ago, so probably this code
path is not (usually) used at all.

The commit introducing the regression changed sign_link_up() first
param from msgb to struct ipaccess_unit, but compiler didn't catch it
because it's being passed as a void pointer.

Fixes: c9c4fd39055ab02c0af59d5519e62edc456e3d0b
Related: OS#3622
Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522
---
M src/input/ipaccess.c
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index da2f04d..f89db15 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -955,9 +955,9 @@
 
 	if (ret == 1 && hh->proto == IPAC_PROTO_IPACCESS) {
 		if (msg_type == IPAC_MSGT_ID_GET) {
-			sign_link = link->line->ops->sign_link_up(msg,
-					link->line,
-					link->ofd->priv_nr);
+			sign_link = link->line->ops->sign_link_up(link->line->ops->cfg.ipa.dev,
+								  link->line,
+								  link->ofd->priv_nr);
 			if (sign_link == NULL) {
 				LOGP(DLINP, LOGL_ERROR,
 					"Unable to set signal link, "

To view, visit change 38805. To unsubscribe, or for help writing mail filters, visit settings.