Attention is currently required from: laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email )

Change subject: osmo_io: Add osmo_io_get_ioops() function ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File include/osmocom/core/osmo_io.h:

https://gerrit.osmocom.org/c/libosmocore/+/36076/comment/3c07305a_ad1f92bd PS1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops); It may make more sense to return a "const struct osmo_io_ops*" so that no copy is needed by default. This also means the struct is not allocated by the user, which may be an advantage if the struct size changes? Not a strong opinion though, just raising the topic.