Attention is currently required from: laforge.

Patch set 1:Code-Review +1

View Change

1 comment:

• File include/osmocom/core/osmo_io.h:

  • Patch Set #1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops);

    It may make more sense to return a "const struct osmo_io_ops*" so that no copy is needed by default. This also means the struct is not allocated by the user, which may be an advantage if the struct size changes?
    Not a strong opinion though, just raising the topic.

To view, visit change 36076. To unsubscribe, or for help writing mail filters, visit settings.