Attention is currently required from: daniel, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File include/osmocom/tcap/Makefile.am: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3b4a153a_10a… : PS5, Line 3: TCAP_RLRQ-apdu.h \ I'd really welcome splitting all these TCAP_* generated headers into a separate variable (and then included here), so that later on we can easily see the skeleton generic files vs the ASN1-specific-file generated ones. File include/osmocom/tcap/TCAP_Unidirectional.h: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/43111d77_4b3… : PS5, Line 16: #include <constr_SEQUENCE.h> All these includes most probably need to be patched during Makefile to be prefixed"<osmocom/tcap/...", otherwise projects including several libraries may end up with collisions. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 5 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 08 Sep 2025 16:02:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes