Attention is currently required from: daniel, osmith.

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )

Change subject: Regenerate code with newer asn1c ......................................................................

Patch Set 5: Code-Review-1

(2 comments)

File include/osmocom/tcap/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3b4a153a_10a2... : PS5, Line 3: TCAP_RLRQ-apdu.h \ I'd really welcome splitting all these TCAP_* generated headers into a separate variable (and then included here), so that later on we can easily see the skeleton generic files vs the ASN1-specific-file generated ones.

File include/osmocom/tcap/TCAP_Unidirectional.h:

https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/43111d77_4b3e... : PS5, Line 16: #include <constr_SEQUENCE.h> All these includes most probably need to be patched during Makefile to be prefixed"<osmocom/tcap/...", otherwise projects including several libraries may end up with collisions.