Attention is currently required from: daniel, osmith.

Patch set 5:Code-Review -1

View Change

2 comments:

• File include/osmocom/tcap/Makefile.am:

  • Patch Set #5, Line 3: TCAP_RLRQ-apdu.h \

    I'd really welcome splitting all these TCAP_* generated headers into a separate variable (and then included here), so that later on we can easily see the skeleton generic files vs the ASN1-specific-file generated ones.

• File include/osmocom/tcap/TCAP_Unidirectional.h:

  • Patch Set #5, Line 16: #include <constr_SEQUENCE.h>

    All these includes most probably need to be patched during Makefile to be prefixed"<osmocom/tcap/...", otherwise projects including several libraries may end up with collisions.

To view, visit change 41022. To unsubscribe, or for help writing mail filters, visit settings.