Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email )

Change subject: s2b: when socket opening fails, stop the S2b module ......................................................................

Patch Set 3:

(1 comment)

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/487936d0_16ce3... : PS3, Line 150: io_lib:format

Not sure why would you want to include a formatted string here, given that above you're already logg […]

Yes maybe true. I'm not sure what's the intended way of returning a reason is. Or what are good examples. IMHO: I thought more into the direction of a python exception, which both contains a type and a human understandable reason.