Attention is currently required from: Timur Davydov.

pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email )

Change subject: stream: make SCTP usage conditional on HAVE_LIBSCTP ......................................................................

Patch Set 1:

(3 comments)

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/88ea3148_8979bd64... : PS1, Line 53: #include <osmocom/netif/sctp.h> You can actually simply move this below inside the ifdef in line 58.

File src/stream_cli.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/cf85410c_b602231a... : PS1, Line 1273: local_addrcnt = cli->local_addrcnt; You could do

case IPPROTO_SCTP: { unsigned int local_addrcnt = cli->local_addrcnt; int flags = OSMO_SOCK_F_CONNECT | OSMO_SOCK_F_NONBLOCK | OSMO_SOCK_F_DSCP(cli->ip_dscp) | OSMO_SOCK_F_PRIO(cli->sk_prio); ... }

to simplify a bit the ifdef blocks.

File src/stream_srv.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/41952/comment/9a5273d9_f8ad5300... : PS1, Line 1050: #ifdef HAVE_LIBSCTP #ifdef HAVE_LIBSCTP if (link->proto == IPPROTO_SCTP) { .... } else #endif { ... }