Attention is currently required from: Timur Davydov.

View Change

3 comments:

• File src/stream.c:

  • Patch Set #1, Line 53: #include <osmocom/netif/sctp.h>

    You can actually simply move this below inside the ifdef in line 58.

• File src/stream_cli.c:

  • Patch Set #1, Line 1273: local_addrcnt = cli->local_addrcnt;

    You could do

        case IPPROTO_SCTP:
        {
         unsigned int local_addrcnt = cli->local_addrcnt;
         int flags = OSMO_SOCK_F_CONNECT | OSMO_SOCK_F_NONBLOCK |
    				OSMO_SOCK_F_DSCP(cli->ip_dscp) | OSMO_SOCK_F_PRIO(cli->sk_prio);
        ...
        }
        
    to simplify a bit the ifdef blocks.

• File src/stream_srv.c:

  • Patch Set #1, Line 1050: #ifdef HAVE_LIBSCTP

    #ifdef HAVE_LIBSCTP
            if (link->proto == IPPROTO_SCTP) {
                ....
            } else 
        #endif
            {
            ...
            }

To view, visit change 41952. To unsubscribe, or for help writing mail filters, visit settings.