Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 ) Change subject: pcuif_proto: add confirmation flag to struct gsm_pcu_if_pch ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comment/bea98297_9d345d25 PS1, Line 17: Depends: osmo-pcu.git Ia202862aafc1f0cb6601574ef61eb9155de11f04 this patch depends on this patch? :) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comment/5a0bbabc_378328a0 PS1, Line 303: imm_ass As somebody not so familiar with the code, I find it confusing that the variable gets a different name here. My understanding is that the struct gsm_pcu_if_pch is used for both immediate assignment and paging, and for imm ass we always set confirm and for paging we don't. Maybe it makes sense to comment this in the struct (right now it says it's only for imm ass, does not mention paging), and just name the variable imm_ass in the struct? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04 Gerrit-Change-Number: 34190 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 13:29:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment