Attention is currently required from: pespin, dexter.

Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 17: Depends: osmo-pcu.git Ia202862aafc1f0cb6601574ef61eb9155de11f04

    this patch depends on this patch? :)

• File src/pcu_l1_if.cpp:

  • Patch Set #1, Line 303: imm_ass

    As somebody not so familiar with the code, I find it confusing that the variable gets a different name here.

    My understanding is that the struct gsm_pcu_if_pch is used for both immediate assignment and paging, and for imm ass we always set confirm and for paging we don't. Maybe it makes sense to comment this in the struct (right now it says it's only for imm ass, does not mention paging), and just name the variable imm_ass in the struct?

To view, visit change 34190. To unsubscribe, or for help writing mail filters, visit settings.