Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30277 )
Change subject: paging: Introduce BTS stat paging:request_queue_length ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/6fc7ead0_e22eadd9 PS1, Line 92: to_be_deleted->bts
Why not paging_bts->bts_statg? I see it's used above.
Because "paging_bts" is not a gsm_bts, but a struct gsm_bts_paging_state, so it would be paging_bts->bts->bts_statg. So it doesn't really matter, it's the same bts pointer in the end.
https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/ef39122c_5f835b11 PS1, Line 470: bts
This is also confusing: above you're decrementing pending_requests_len via 'bts_entry', but here you […]
Same, bts_entry is struct gsm_bts_paging_state, which is basically "bts->paging".