Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34485?usp=email )
Change subject: ASCI: Increase channel request history to 5 entries ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/34485/comment/31a3517f_5a9730f8 PS5, Line 9: 3 entries are enough for random access on CCCH
Is it strictly necessary to remember up to exactly 3 requests? […]
No, we must compare only the last 3 channel requests for an IMM.ASS or reject, as defined in the specs. On uplink request we need to remember up to 5 uplink requests.
I added a comment with reference to the specs in the fixup.
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34485/comment/03a0ac8a_c82756e4 PS5, Line 2367: static int gsm48_match_ra(struct osmocom_ms *ms, struct gsm48_req_ref *ref, int hist_num)
unsigned. […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34485/comment/812bb6c7_a03de13f PS5, Line 2495: if (gsm48_match_ra(ms, &ia->req_ref, 3)) {
sounds like we want to have defined for magic numbers 3 and 5 ;)
Done
-
jolly